-
-
Notifications
You must be signed in to change notification settings - Fork 829
Conversation
- Add a long name audio file to check file name overflow - Check player layout on monospace font - Check player layout on high contrast theme - Check player layout on IRC layout (should be same as modern layout) - Percy snapshots of mx_MAudioBody (hide seekbar temporarily) - Output snapshot logs Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…ercy tests Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for this, @luixxiul, it looks like a great addition.
I've started taking a look but I have a few questions.
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, but I'd like to see what Percy does with it. Trying to find out whether we can make Percy run on this PR...
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Apparently we've run out of Percy quota, and it won't be restored until the 21st April, so I think we'll have to just go ahead and merge this |
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@richvdh it looks auto merge will not happen until the quota is restored. Should we wait? |
@luixxiul can you pull latest develop please |
I checked the latest snapshots and they have been successfully taken: https://percy.io/dfde73bd/matrix-react-sdk/builds/26747313/search?searchParam=audio%20player |
This PR adds E2E test of audio player.
For element-hq/element-web#24747 and element-hq/element-web#22542
This test includes taking Percy snapshots to check if the player is rendered properly on various scenarios (on light theme, dark theme, high contrast theme, with a reply, a reply chain, IRC layout, modern/group layout, bubble layout).
I would like to ask a reviewer to add
X-Needs-Percy
label so that I could check if the Percy tests should work as intended and fix the issue before this PR is merged and the test becomes a flaky one ondevelop
branch (I implemented several ideas which hopefully should prevent the test from becoming flaky).The Percy screenshots should be captured as below (captured manually on Cypress). Please note that the seek bar is hidden on Percy due to the flaky test reported here. Please note there is a difference between a local Cypress run and a Percy snapshot about how the list style is applied (element-hq/element-web#24969)
(Modern layout)
(bubble layout)
(modern layout)
(bubble layout)
(modern layout)
Broken: reported here
(bubble layout)
Broken: reported here
(modern layout)
(bubble layout)
(modern layout)
(bubble layout)
type: task
Retry of #10407
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.